-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: cli: adding wallet tests #8079
Conversation
…_tests merging cli-chain-tests for mock full api function dependency
@TheMenko You should check for output of cli commands, but don't be to specific, don't do exact string matching but look for some important substrings. For example if a CLI command outputs a bunch of text but somewhere in that text you expect to see a specific address, look for that address using |
update branch from master
cli/wallet_test.go
Outdated
err := app.Run([]string{"wallet", "list", "addr-only"}) | ||
assert.NoError(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do some asserts on the output here
Related Issues
This PR is related to #8048.
The chain cli test branch have been merged into this PR, so #8048 should be merged first.
Proposed Changes
This PR adds wallet tests for CLI.
Most of the wallet cli commands have been tested.
It uses the mocked API from chain cli test branch.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps