Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove inaccurate comment in sealtasks #7977

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jan 19, 2022

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner January 19, 2022 09:46
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #7977 (c41ccb6) into master (c0f29ea) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7977      +/-   ##
==========================================
- Coverage   39.33%   39.28%   -0.06%     
==========================================
  Files         658      658              
  Lines       71129    71129              
==========================================
- Hits        27980    27941      -39     
- Misses      38335    38368      +33     
- Partials     4814     4820       +6     
Impacted Files Coverage Δ
extern/sector-storage/sealtasks/task.go 81.81% <ø> (ø)
extern/sector-storage/worker_tracked.go 79.09% <0.00%> (-7.28%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-5.89%) ⬇️
chain/sync_manager.go 67.39% <0.00%> (-5.28%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-3.64%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
extern/sector-storage/stores/local.go 59.16% <0.00%> (-0.84%) ⬇️
extern/sector-storage/sched.go 83.12% <0.00%> (-0.83%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f29ea...c41ccb6. Read the comment docs.

@arajasek arajasek merged commit ff845aa into master Jan 21, 2022
@arajasek arajasek deleted the chore/sealtasks-comment branch January 21, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants