Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: chain: Make drand logs in daemon less noisy #7955

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

RobQuistNL
Copy link
Contributor

@RobQuistNL RobQuistNL commented Jan 14, 2022

Makes logs less noisy

Proposed Changes

Changes log level for drand fetching from info to debug

Additional Info

Nothing special.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Makes logs less noisy
@RobQuistNL RobQuistNL requested a review from a team as a code owner January 14, 2022 02:52
@RobQuistNL RobQuistNL changed the title Make drand logs in daemon less noisy perf: chain: Make drand logs in daemon less noisy Jan 14, 2022
@RobQuistNL
Copy link
Contributor Author

CI failing seems to have nothing to do with my changes..

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #7955 (bb514b8) into master (da6752e) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7955      +/-   ##
==========================================
- Coverage   39.37%   39.31%   -0.06%     
==========================================
  Files         658      658              
  Lines       71142    71142              
==========================================
- Hits        28014    27973      -41     
- Misses      38319    38343      +24     
- Partials     4809     4826      +17     
Impacted Files Coverage Δ
chain/beacon/drand/drand.go 0.00% <0.00%> (ø)
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
extern/sector-storage/faults.go 27.95% <0.00%> (-4.31%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
miner/miner.go 56.39% <0.00%> (-2.96%) ⬇️
chain/sync.go 65.00% <0.00%> (-2.67%) ⬇️
extern/sector-storage/stores/index_locks.go 64.28% <0.00%> (-2.39%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-1.97%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da6752e...bb514b8. Read the comment docs.

@Kubuxu Kubuxu merged commit 026c510 into filecoin-project:master Feb 9, 2022
@silvianetobessa
Copy link

Hello @RobQuistNL !

This contribution to the Filecoin codebase was voted as impactful during Q1 and is eligible for a FIL prize as part of a Protocol Labs experiment to reward open source contributions from the community (see full details here).

Please reach out to us through [email protected] to receive the instructions on how to claim your reward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants