Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #7747 sealing: Adding conf variable for capping number of concurrent unsealing jobs #7884

Merged
merged 5 commits into from
Jan 13, 2022

Conversation

laudiacay
Copy link
Contributor

@laudiacay laudiacay commented Jan 5, 2022

Related Issues

Closes #7747

Proposed Changes

Will add a variable to cap number of concurrent unsealing jobs so as to prevent overwhelming the miner

Additional Info

See the issue for more details.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@laudiacay laudiacay requested a review from magik6k January 5, 2022 02:40
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #7884 (b9eae2d) into master (3fb71cd) will decrease coverage by 0.03%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7884      +/-   ##
==========================================
- Coverage   39.38%   39.35%   -0.04%     
==========================================
  Files         655      655              
  Lines       70254    70266      +12     
==========================================
- Hits        27673    27650      -23     
- Misses      37818    37848      +30     
- Partials     4763     4768       +5     
Impacted Files Coverage Δ
markets/dagstore/miner_api.go 64.21% <82.35%> (+1.11%) ⬆️
node/config/def.go 97.43% <100.00%> (+0.01%) ⬆️
node/modules/storageminer_dagstore.go 61.53% <100.00%> (ø)
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
miner/miner.go 55.62% <0.00%> (-3.65%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-1.97%) ⬇️
extern/sector-storage/sched.go 83.12% <0.00%> (-1.65%) ⬇️
chain/store/store.go 63.50% <0.00%> (-1.34%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fb71cd...b9eae2d. Read the comment docs.

@laudiacay laudiacay marked this pull request as ready for review January 10, 2022 15:57
@laudiacay laudiacay requested a review from a team as a code owner January 10, 2022 15:57
@jennijuju
Copy link
Member

Nice!

@laudiacay laudiacay merged commit da6752e into master Jan 13, 2022
@laudiacay laudiacay deleted the adding-unsealing-job-limit branch January 13, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add synchronous UNS job amount to configuration
3 participants