Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapcraft grade no develgrade #7802

Merged
merged 4 commits into from
Jan 4, 2022
Merged

Conversation

coryschwartz
Copy link

No description provided.

@coryschwartz
Copy link
Author

This works when pushing to the snapcraft stable channel.

https://app.circleci.com/pipelines/github/filecoin-project/lotus/18505/workflows/223874ac-2406-4bc8-a85a-1b6da8e1b636/jobs/324378

This was used to push version 232 to the stable channel

https://snapcraft.io/lotus-filecoin/releases

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #7802 (65ecca2) into master (dc26f3b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7802      +/-   ##
==========================================
- Coverage   39.57%   39.54%   -0.04%     
==========================================
  Files         640      640              
  Lines       68469    68469              
==========================================
- Hits        27097    27076      -21     
- Misses      36728    36738      +10     
- Partials     4644     4655      +11     
Impacted Files Coverage Δ
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-3.93%) ⬇️
chain/exchange/client.go 49.15% <0.00%> (-3.82%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
miner/miner.go 54.96% <0.00%> (-2.65%) ⬇️
chain/gen/gen.go 68.61% <0.00%> (-1.24%) ⬇️
chain/store/store.go 63.00% <0.00%> (-1.17%) ⬇️
extern/sector-storage/sched_worker.go 78.48% <0.00%> (-1.17%) ⬇️
chain/messagepool/selection.go 80.12% <0.00%> (-0.82%) ⬇️
chain/messagepool/messagepool.go 57.79% <0.00%> (-0.62%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc26f3b...65ecca2. Read the comment docs.

@jennijuju jennijuju mentioned this pull request Dec 17, 2021
5 tasks
@coryschwartz coryschwartz marked this pull request as ready for review December 17, 2021 20:40
@coryschwartz coryschwartz requested a review from a team as a code owner December 17, 2021 20:40
@magik6k magik6k merged commit b72b12a into master Jan 4, 2022
@magik6k magik6k deleted the snapcraft-grade-no-develgrade branch January 4, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants