Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitStore: supress compaction near upgrades #7734

Merged
merged 4 commits into from
Dec 3, 2021

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Dec 3, 2021

This adds the necessary logic to suppress compaction near upgrades and avoid issues with garbage collection of migrated state; see #7565

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #7734 (489782e) into master (9331714) will decrease coverage by 0.01%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7734      +/-   ##
==========================================
- Coverage   39.58%   39.57%   -0.02%     
==========================================
  Files         640      640              
  Lines       68332    68350      +18     
==========================================
- Hits        27052    27051       -1     
- Misses      36647    36657      +10     
- Partials     4633     4642       +9     
Impacted Files Coverage Δ
node/modules/chain.go 76.00% <0.00%> (ø)
blockstore/splitstore/splitstore.go 26.87% <100.00%> (+3.00%) ⬆️
blockstore/splitstore/splitstore_compact.go 51.76% <100.00%> (+0.65%) ⬆️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
miner/miner.go 55.62% <0.00%> (-2.99%) ⬇️
chain/events/events_height.go 68.90% <0.00%> (-2.53%) ⬇️
blockstore/buffered.go 40.00% <0.00%> (-2.23%) ⬇️
chain/stmgr/searchwait.go 66.02% <0.00%> (-1.29%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9331714...489782e. Read the comment docs.

@magik6k magik6k merged commit 9d14342 into master Dec 3, 2021
@magik6k magik6k deleted the feat/splitstore-upgrade-protection branch December 3, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants