Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrieval: Only output matching nodes, MatchPath dagspec #7706

Merged
merged 12 commits into from
Nov 29, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 29, 2021

Depends on ipld/go-ipld-selector-text-lite#5

todo:

  • Use go-ipld-selector-text-lite master when merged
  • Test non-path-matching retrieval
  • Make sure that ls / cat still works

@magik6k magik6k requested a review from a team as a code owner November 29, 2021 19:03
@magik6k magik6k marked this pull request as draft November 29, 2021 19:03
@jennijuju jennijuju added the P2 P2: Should be resolved label Nov 29, 2021
@jennijuju
Copy link
Member

also need ipld/go-ipld-selector-text-lite#5

@jennijuju jennijuju added this to the v1.13.2 milestone Nov 29, 2021
api/types.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #7706 (468b90a) into master (77d75b7) will decrease coverage by 0.00%.
The diff coverage is 59.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7706      +/-   ##
==========================================
- Coverage   39.54%   39.53%   -0.01%     
==========================================
  Files         638      638              
  Lines       68045    68069      +24     
==========================================
+ Hits        26905    26911       +6     
- Misses      36509    36536      +27     
+ Partials     4631     4622       -9     
Impacted Files Coverage Δ
api/types.go 52.77% <ø> (ø)
cli/client_retr.go 21.29% <0.00%> (-0.24%) ⬇️
node/impl/client/client.go 50.53% <65.62%> (+0.84%) ⬆️
api/v0api/v1_wrapper.go 14.20% <100.00%> (+0.49%) ⬆️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-7.28%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-1.96%) ⬇️
extern/storage-sealing/fsm.go 55.77% <0.00%> (-1.60%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d75b7...468b90a. Read the comment docs.

@magik6k magik6k marked this pull request as ready for review November 29, 2021 20:15
Copy link
Collaborator

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

2 more suggestions, no functional changes

node/impl/client/client.go Outdated Show resolved Hide resolved
api/types.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit f399422 into master Nov 29, 2021
@magik6k magik6k deleted the feat/ret-matchding-cars branch November 29, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 P2: Should be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants