Add verbose mode to lotus-miner pieces list-cids #7699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/listcids-verbose
branch
from
0d4dd08
to
a6fbf5b
Compare
magik6k
force-pushed
the
feat/listcids-verbose
branch
from
a6fbf5b
to
f8b1328
Compare
Codecov Report
@@ Coverage Diff @@
## master #7699 +/- ##
==========================================
- Coverage 39.56% 39.43% -0.13%
==========================================
Files 637 637
Lines 67924 67957 +33
==========================================
- Hits 26872 26800 -72
- Misses 36446 36532 +86
- Partials 4606 4625 +19
Continue to review full report at Codecov.
|
arajasek
reviewed
Nov 29, 2021
| @@ -61,9 +68,54 @@ var piecesListCidInfosCmd = &cli.Command{ | |||
| return err | |||
| } | |||
|
|
|||
| w := tablewriter.New(tablewriter.Col("CID"), | |||
There was a problem hiding this comment.
Isn't this gonna get printed in non verbose mode too
There was a problem hiding this comment.
Nope, tablewriter doesn't print anything with no entries
arajasek
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.