Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove api and jaeger env from docker file #7624

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

travisperson
Copy link
Contributor

Having MINER_API_INFO and FULLNODE_API_INFO set by default force read-only mode and restricted the ability for broader usage of the docker files produced for general consumption

@travisperson travisperson requested a review from a team as a code owner November 11, 2021 15:00
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #7624 (73182cf) into master (ef0771e) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7624      +/-   ##
==========================================
- Coverage   39.77%   39.67%   -0.11%     
==========================================
  Files         633      633              
  Lines       67263    67263              
==========================================
- Hits        26757    26687      -70     
- Misses      35911    35978      +67     
- Partials     4595     4598       +3     
Impacted Files Coverage Δ
chain/actors/builtin/market/v5.go 23.38% <0.00%> (-16.13%) ⬇️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-9.81%) ⬇️
extern/sector-storage/worker_tracked.go 76.53% <0.00%> (-8.17%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
markets/storageadapter/ondealsectorcommitted.go 77.33% <0.00%> (-4.00%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
chain/actors/builtin/miner/v5.go 35.69% <0.00%> (-2.47%) ⬇️
miner/miner.go 53.97% <0.00%> (-1.99%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-1.96%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef0771e...73182cf. Read the comment docs.

@magik6k
Copy link
Contributor

magik6k commented Nov 18, 2021

I guess #7631 also did this.

@travisperson do we still want to merge the other changes from this PR?

@travisperson
Copy link
Contributor Author

Yes, the removal of the API env is the important bit of this PR.

@magik6k magik6k merged commit 77dd022 into master Nov 22, 2021
@magik6k magik6k deleted the feat/docker-file-generic branch November 22, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants