Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout flag to wait-api command #7592

Merged
merged 1 commit into from
Nov 4, 2021
Merged

add timeout flag to wait-api command #7592

merged 1 commit into from
Nov 4, 2021

Conversation

travisperson
Copy link
Contributor

This should maintain the same behavior, except with a change that an error ERROR: context canceled will be printed when the command is killed with ctrl-c, as opposed to no error prior.

@travisperson travisperson requested a review from a team as a code owner November 2, 2021 15:54
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #7592 (60b3ae2) into master (e0a9cae) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7592      +/-   ##
==========================================
- Coverage   39.88%   39.77%   -0.12%     
==========================================
  Files         633      633              
  Lines       67098    67104       +6     
==========================================
- Hits        26765    26693      -72     
- Misses      35740    35798      +58     
- Partials     4593     4613      +20     
Impacted Files Coverage Δ
cli/wait.go 0.00% <0.00%> (ø)
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-7.28%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
storage/wdpost_sched.go 75.24% <0.00%> (-5.95%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
miner/miner.go 55.62% <0.00%> (-1.99%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-1.96%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a9cae...60b3ae2. Read the comment docs.

@magik6k magik6k merged commit 40d5c6f into master Nov 4, 2021
@magik6k magik6k deleted the feat/wait-api-flags branch November 4, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants