-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the withdrawn amount unit #7563
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7563 +/- ##
==========================================
- Coverage 39.85% 39.78% -0.08%
==========================================
Files 633 633
Lines 67098 67098
==========================================
- Hits 26742 26694 -48
- Misses 35758 35798 +40
- Partials 4598 4606 +8
Continue to review full report at Codecov.
|
chain/types/fil.go
Outdated
@@ -122,6 +124,12 @@ func ParseFIL(s string) (FIL, error) { | |||
return FIL{r.Num()}, nil | |||
} | |||
|
|||
func ParseAttoFilToFIL(atto abi.TokenAmount) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't call it Parse, rather Format. Parse is usually reserved from going from string -> number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this function since we have a better thing already!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think types.FIL(withdrawn)
should already fulfil the same purpose.
Please reject the review if for some reason it doesn't.
You are totally right! updated! |
fixes #7561
shown in FIL