Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To make Deep happy #7546

Merged
merged 1 commit into from
Oct 26, 2021
Merged

To make Deep happy #7546

merged 1 commit into from
Oct 26, 2021

Conversation

jennijuju
Copy link
Member

@jennijuju jennijuju commented Oct 21, 2021

resolves #7543

@jennijuju jennijuju requested a review from a team as a code owner October 21, 2021 00:54
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #7546 (9369c54) into master (67c732a) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7546      +/-   ##
==========================================
- Coverage   39.90%   39.82%   -0.08%     
==========================================
  Files         632      632              
  Lines       67049    67049              
==========================================
- Hits        26756    26704      -52     
- Misses      35699    35739      +40     
- Partials     4594     4606      +12     
Impacted Files Coverage Δ
cli/filplus.go 0.00% <ø> (ø)
node/modules/dtypes/mpool.go 87.50% <0.00%> (-12.50%) ⬇️
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-7.28%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
node/impl/full/mpool.go 25.21% <0.00%> (-1.74%) ⬇️
miner/miner.go 55.96% <0.00%> (-1.66%) ⬇️
chain/gen/gen.go 68.61% <0.00%> (-1.24%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c732a...9369c54. Read the comment docs.

@dkkapur
Copy link
Contributor

dkkapur commented Oct 21, 2021

Amazing - would love to see it ship!

@galen-mcandrew
Copy link

Agree, would love to see this

@jennijuju jennijuju merged commit a94a48f into master Oct 26, 2021
@jennijuju jennijuju deleted the jen/deep-da-boss-order branch October 26, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "lotus filplus check-notaries-datacap" to "lotus filplus check-notary-datacap"
4 participants