-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sector storage groups #7453
Merged
Merged
Sector storage groups #7453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7453 +/- ##
=======================================
Coverage 39.60% 39.60%
=======================================
Files 635 635
Lines 67551 67581 +30
=======================================
+ Hits 26754 26766 +12
- Misses 36203 36210 +7
- Partials 4594 4605 +11
Continue to review full report at Codecov.
|
magik6k
force-pushed
the
feat/storage-groups
branch
from
October 6, 2021 13:45
876cc58
to
aa31895
Compare
magik6k
force-pushed
the
feat/storage-groups
branch
from
October 18, 2021 17:54
1bd3454
to
2333687
Compare
magik6k
force-pushed
the
feat/storage-groups
branch
2 times, most recently
from
November 22, 2021 12:16
80bf7e4
to
2fdeeeb
Compare
arajasek
approved these changes
Nov 22, 2021
jennijuju
reviewed
Nov 23, 2021
magik6k
force-pushed
the
feat/storage-groups
branch
from
November 23, 2021 15:16
2fdeeeb
to
a2cf50e
Compare
magik6k
force-pushed
the
feat/storage-groups
branch
from
November 23, 2021 15:23
a2cf50e
to
b522901
Compare
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new optional fields to
sectorstore.json
:Groups []string
- list of group names the storage path belongs to.AllowTo []string
- list of group names to which sectors can be fetched to from this storage path.Those two should allow for creating worker groups, and avoiding unnecesarily moving data between multi-purpose workers. For example in the following setup:
Groups: ["example-storage-group-1"]
Groups: ["example-seal-group-1"], AllowTo: ["example-seal-group-1"]
Groups: ["example-seal-group-2"], AllowTo: ["example-seal-group-2"]
AllowTo: ["example-seal-group-1""]
Without storage groups, PC2 tasks on workers 1/2 could be scheduled with sector data from other workers, which would often waste bandwidth and occasionally block processing on fetching data.
With storage groups configured as above, sectors which had PC1 done on worker1 / worker2 will always execute PC2 on the same worker. Sectors from worker3 will only go to worker1 for PC2
Groups can be setup in two ways:
storage attach --init
command with the new--groups
/--allow-to
flags[path]/sectorstore.json
, then restarting lotus-miner/workerGroups:
AllowTo:
TODO: