-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StateSearchMsg: Correct usage of the allowReplaced flag #7450
Conversation
0040324
to
7cdecfb
Compare
Codecov Report
@@ Coverage Diff @@
## master #7450 +/- ##
==========================================
- Coverage 39.19% 39.14% -0.05%
==========================================
Files 630 630
Lines 66762 66767 +5
==========================================
- Hits 26169 26138 -31
- Misses 36020 36054 +34
- Partials 4573 4575 +2
Continue to review full report at Codecov.
|
Can use a test 🐱🐱 |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. Except for the deps and the unrelated change.
testplans/lotus-soup/go.mod
Outdated
@@ -26,7 +26,7 @@ require ( | |||
github.com/ipfs/go-log/v2 v2.3.0 | |||
github.com/ipfs/go-merkledag v0.3.2 | |||
github.com/ipfs/go-unixfs v0.2.6 | |||
github.com/ipld/go-car v0.3.1-null-padded-files | |||
github.com/ipld/go-car v0.3.2-0.20211001225732-32d0d9933823 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a commit on master, and is not tagged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then ytf does it magically get changed i hate gomod idk how anything works is it my ide doing this??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷? What go version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see... It was already broken, the go mod just wasn't updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was broken? i honestly dunno how any of this works, i'm probably the one who broke it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to a non-tagged commit not on master. It's not broken yet, but will be if the branch the commit lives on gets a force-push (which happens frequently in this particular branch).
373a5df
to
bd2176c
Compare
Fixes #7009
Also fixes all uses of
StateSearchMsg
withallowReplaced
set to false.