Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateSearchMsg: Correct usage of the allowReplaced flag #7450

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Oct 6, 2021

Fixes #7009

Also fixes all uses of StateSearchMsg with allowReplaced set to false.

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #7450 (bd2176c) into master (26ae8bb) will decrease coverage by 0.04%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7450      +/-   ##
==========================================
- Coverage   39.19%   39.14%   -0.05%     
==========================================
  Files         630      630              
  Lines       66762    66767       +5     
==========================================
- Hits        26169    26138      -31     
- Misses      36020    36054      +34     
- Partials     4573     4575       +2     
Impacted Files Coverage Δ
chain/stmgr/searchwait.go 66.02% <81.81%> (+1.31%) ⬆️
chain/gen/gen.go 69.84% <100.00%> (+1.42%) ⬆️
journal/types.go 86.66% <0.00%> (-13.34%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
storage/wdpost_sched.go 77.22% <0.00%> (-3.97%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
extern/storage-sealing/fsm.go 56.22% <0.00%> (-2.82%) ⬇️
journal/fsjournal/fs.go 66.66% <0.00%> (-2.78%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ae8bb...bd2176c. Read the comment docs.

@jennijuju
Copy link
Member

Can use a test 🐱🐱

@arajasek
Copy link
Contributor Author

arajasek commented Oct 6, 2021

Can use a test 🐱🐱

done

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Except for the deps and the unrelated change.

@@ -26,7 +26,7 @@ require (
github.com/ipfs/go-log/v2 v2.3.0
github.com/ipfs/go-merkledag v0.3.2
github.com/ipfs/go-unixfs v0.2.6
github.com/ipld/go-car v0.3.1-null-padded-files
github.com/ipld/go-car v0.3.2-0.20211001225732-32d0d9933823
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😡

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a commit on master, and is not tagged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then ytf does it magically get changed i hate gomod idk how anything works is it my ide doing this??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷? What go version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see... It was already broken, the go mod just wasn't updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was broken? i honestly dunno how any of this works, i'm probably the one who broke it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to a non-tagged commit not on master. It's not broken yet, but will be if the branch the commit lives on gets a force-push (which happens frequently in this particular branch).

chain/stmgr/searchwait.go Outdated Show resolved Hide resolved
chain/gen/gen.go Show resolved Hide resolved
@arajasek arajasek merged commit a324b3f into master Oct 6, 2021
@arajasek arajasek deleted the arajasek-patch-1 branch October 6, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If miner replaces publish deal message, it does not update that in its deal state
3 participants