sealing: Recover sectors after failed AddPiece

[magik6k]

No description provided.

[codecov]

Codecov Report

Merging #7444 (cadbd00) into master (fc10281) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##           master    #7444   +/-   ##
=======================================
  Coverage   39.54%   39.54%           
=======================================
  Files         616      616           
  Lines       65295    65297    +2     
=======================================
+ Hits        25818    25819    +1     
- Misses      34980    34988    +8     
+ Partials     4497     4490    -7     

Impacted Files	Coverage Δ
extern/storage-sealing/fsm.go	58.56% <0.00%> (+1.13%)	⬆️
extern/storage-sealing/fsm_events.go	54.16% <0.00%> (-0.46%)	⬇️
extern/storage-sealing/input.go	55.35% <0.00%> (+0.19%)	⬆️
extern/storage-sealing/sector_state.go	92.30% <100.00%> (ø)
chain/actors/builtin/miner/diff.go	48.52% <0.00%> (-10.30%)	⬇️
extern/sector-storage/sched_resources.go	75.00% <0.00%> (-9.38%)	⬇️
extern/sector-storage/manager_calltracker.go	57.70% <0.00%> (-4.85%)	⬇️
chain/exchange/client.go	52.96% <0.00%> (-1.70%)	⬇️
itests/kit/blockminer.go	93.65% <0.00%> (-1.59%)	⬇️
extern/sector-storage/sched_worker.go	78.38% <0.00%> (-0.74%)	⬇️
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc10281...cadbd00. Read the comment docs.

[magik6k]

Review note: we do have offset in AddPiece already, calculated from the existingPieces thing which only has valid pieces

[neondragon]

Seems to work, perhaps not optimally but it saved a deal from being lost.

A piece failed to add to a sector, the sector ended up as a CC sector:

Event Log:
0.	2021-10-12 16:41:00 +0000 UTC:	[event;sealing.SectorStart]	{"User":{"ID":4510,"SectorType":8}}
1.	2021-10-12 16:41:00 +0000 UTC:	[event;sealing.SectorAddPiece]	{"User":{}}
2.	2021-10-12 16:44:50 +0000 UTC:	[event;sealing.SectorAddPieceFailed]	{"User":{}}
	writing piece: storage call error 0: pr read error: read tcp 1.1.1.1:3056->2.2.2.2:55220: read: connection timed out
3.	2021-10-12 16:44:50 +0000 UTC:	[event;sealing.SectorRetryWaitDeals]	{"User":{}}
4.	2021-10-12 17:41:00 +0000 UTC:	[event;sealing.SectorStartPacking]	{"User":{}}
5.	2021-10-12 17:46:13 +0000 UTC:	[event;sealing.SectorPacked]	{"User":{"FillerPieces":[{"Size":34359738368,"PieceCID":{"/":"baga6ea4seaqao7s73y24kcutaosvacpdjgfe5pw76ooefnyqw4ynr3d2y6x2mpq"}}]}}

The piece was added to another sector, sealed, and the storage deal is StorageDealActive.