-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for deal start epoch on SectorAddPieceToAny #7407
check for deal start epoch on SectorAddPieceToAny #7407
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7407 +/- ##
==========================================
- Coverage 39.53% 39.51% -0.02%
==========================================
Files 616 616
Lines 65281 65295 +14
==========================================
- Hits 25810 25804 -6
- Misses 34982 34992 +10
- Partials 4489 4499 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to have a config for minimum start epoch 'buffer' to give time for sealing
dcc6fd4
to
9d78d45
Compare
9d78d45
to
809289f
Compare
(rebased to update config docs) |
Should fix: #5137
This PR is:
SectorAddPieceToAny
.StartEpochSealingBuffer
to bothSectorAddPieceToAny
, as well as tovalidateDeal
prior to sending aPublishStorageDeals
message, to account for some time necessary to seal a sector.At the moment I have added
StartEpochSealingBuffer
to be 480 by default == which is 4 hours, and I think this is reasonable. I am not sure if there are miners out there that go fromPublishStorageDeals
to a sealed sector faster than 4 hours...