Add v6 actors #7357
Merged
Add v6 actors #7357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
asr/v6actors
branch
2 times, most recently
from
95b3c33 to
fc28e6b
Compare
Codecov Report
@@ Coverage Diff @@
## feat/nv14 #7357 +/- ##
=============================================
+ Coverage 39.06% 39.27% +0.20%
=============================================
Files 614 627 +13
Lines 64996 66084 +1088
=============================================
+ Hits 25389 25952 +563
- Misses 35204 35652 +448
- Partials 4403 4480 +77
Continue to review full report at Codecov.
|
magik6k
reviewed
Sep 21, 2021
Comment on lines
+75
to
+82
| {{else}} | ||
| miner{{.}}.PreCommitSealProofTypesV8[t+abi.RegisteredSealProof_StackedDrg2KiBV1_1] = struct{}{} | ||
| wpp, err = t.RegisteredWindowPoStProof() | ||
| if err != nil { | ||
| // Fine to panic, this is a test-only method | ||
| panic(err) | ||
| } | ||
|
|
There was a problem hiding this comment.
How is this different from the v5 thing?
There was a problem hiding this comment.
for v5 we := define wpp and err for the first time, v6 onwards uses the same variables
arajasek
force-pushed
the
asr/v6actors
branch
from
fc28e6b to
7b4c657
Compare
magik6k
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7295