Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itests: remove cid equality comparison #7292

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

nonsense
Copy link
Member

@nonsense nonsense commented Sep 7, 2021

Fixes flaky test introduced in #7276

In-memory repo is using the MapDatastore, which doesn't return sorted CIDs list for imported files into Filecoin, hence we got a flaky test for the second comparison for the second deal.

I am removing the CID comparison here altogether, as this is somewhat independent from what this test is testing.

@nonsense nonsense force-pushed the nonsense/fix-flaky-test-increase-deal-size branch from eb48e47 to 567d054 Compare September 7, 2021 08:57
@nonsense nonsense changed the title itests: increase deal size to 1MiB itests: remove cid equality comparison Sep 7, 2021
@nonsense nonsense requested a review from dirkmc September 7, 2021 08:58
@nonsense nonsense marked this pull request as ready for review September 7, 2021 08:59
@nonsense nonsense requested a review from a team as a code owner September 7, 2021 08:59
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #7292 (567d054) into master (0216697) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7292   +/-   ##
=======================================
  Coverage   39.13%   39.13%           
=======================================
  Files         614      614           
  Lines       64965    64965           
=======================================
+ Hits        25422    25426    +4     
+ Misses      35135    35133    -2     
+ Partials     4408     4406    -2     
Impacted Files Coverage Δ
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
extern/sector-storage/manager_calltracker.go 59.03% <0.00%> (-3.53%) ⬇️
miner/miner.go 52.31% <0.00%> (-3.32%) ⬇️
extern/sector-storage/sched_worker.go 77.97% <0.00%> (-0.73%) ⬇️
chain/store/store.go 63.66% <0.00%> (-0.71%) ⬇️
chain/sync.go 64.94% <0.00%> (-0.34%) ⬇️
storage/wdpost_changehandler.go 98.11% <0.00%> (ø)
extern/sector-storage/stores/local.go 58.80% <0.00%> (ø)
chain/messagepool/messagepool.go 57.12% <0.00%> (+0.24%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0216697...567d054. Read the comment docs.

@Stebalien Stebalien merged commit b093d8a into master Sep 7, 2021
@Stebalien Stebalien deleted the nonsense/fix-flaky-test-increase-deal-size branch September 7, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants