Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce lotus-miner startup spam #7205

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Reduce lotus-miner startup spam #7205

merged 1 commit into from
Aug 27, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Aug 27, 2021

Those 2 logs would be printed on each lotus-miner startup for each sector, which even for not-so-big miners means tens of thousands of rather useless log lines on every restart

@magik6k magik6k requested a review from a team as a code owner August 27, 2021 17:43
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #7205 (2293ecd) into master (7db4dda) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7205      +/-   ##
==========================================
+ Coverage   39.10%   39.12%   +0.02%     
==========================================
  Files         608      608              
  Lines       64604    64602       -2     
==========================================
+ Hits        25262    25277      +15     
+ Misses      34951    34935      -16     
+ Partials     4391     4390       -1     
Impacted Files Coverage Δ
extern/sector-storage/manager.go 64.94% <ø> (-0.11%) ⬇️
extern/storage-sealing/states_proving.go 24.61% <ø> (-1.15%) ⬇️
chain/stmgr/call.go 62.00% <0.00%> (-4.00%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
chain/vm/vm.go 59.47% <0.00%> (-1.12%) ⬇️
paychmgr/simple.go 79.93% <0.00%> (-0.93%) ⬇️
miner/miner.go 51.65% <0.00%> (-0.67%) ⬇️
chain/messagepool/selection.go 80.93% <0.00%> (+0.40%) ⬆️
chain/sync.go 61.63% <0.00%> (+0.43%) ⬆️
markets/storageadapter/dealpublisher.go 84.18% <0.00%> (+0.56%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db4dda...2293ecd. Read the comment docs.

@Stebalien Stebalien merged commit 714635c into master Aug 27, 2021
@Stebalien Stebalien deleted the feat/reduce-startup-spam branch August 27, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants