Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config for disabling NAT port mapping #7204

Merged
merged 2 commits into from
Aug 27, 2021
Merged

config for disabling NAT port mapping #7204

merged 2 commits into from
Aug 27, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Aug 27, 2021

Should give users a way to address issues like #2571

@magik6k magik6k requested a review from a team as a code owner August 27, 2021 17:18
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #7204 (3708a7a) into master (982a377) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7204   +/-   ##
=======================================
  Coverage   39.19%   39.19%           
=======================================
  Files         608      608           
  Lines       64559    64559           
=======================================
+ Hits        25302    25307    +5     
+ Misses      34877    34872    -5     
  Partials     4380     4380           
Impacted Files Coverage Δ
node/builder.go 83.70% <ø> (ø)
chain/actors/builtin/paych/paych.go 16.88% <0.00%> (-5.20%) ⬇️
extern/sector-storage/sched_worker.go 76.53% <0.00%> (-1.45%) ⬇️
chain/sync_manager.go 66.77% <0.00%> (-0.94%) ⬇️
chain/messagepool/selection.go 80.52% <0.00%> (-0.82%) ⬇️
extern/storage-sealing/fsm.go 56.62% <0.00%> (-0.41%) ⬇️
chain/sync.go 61.20% <0.00%> (-0.22%) ⬇️
storage/wdpost_changehandler.go 98.58% <0.00%> (+0.94%) ⬆️
lib/rpcenc/reader.go 71.78% <0.00%> (+1.48%) ⬆️
extern/sector-storage/sched.go 84.71% <0.00%> (+1.65%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982a377...3708a7a. Read the comment docs.

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants