Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional mined block list to miner info #7202

Merged
merged 4 commits into from
Aug 27, 2021
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Aug 27, 2021

This is #5290 with conflicts resolved, and with some tweaks (mostly added a progress indicator which is useful for miners who only mine a block or two per month, where this gets a little slow (2-3 min per month))

@magik6k magik6k requested a review from a team as a code owner August 27, 2021 11:41
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #7202 (22d75f4) into master (a63f5c8) will increase coverage by 0.04%.
The diff coverage is 4.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7202      +/-   ##
==========================================
+ Coverage   39.07%   39.11%   +0.04%     
==========================================
  Files         608      608              
  Lines       64559    64604      +45     
==========================================
+ Hits        25226    25272      +46     
- Misses      34953    34960       +7     
+ Partials     4380     4372       -8     
Impacted Files Coverage Δ
cmd/lotus-miner/info.go 59.63% <4.25%> (-9.36%) ⬇️
node/modules/dtypes/mpool.go 87.50% <0.00%> (-12.50%) ⬇️
miner/warmup.go 76.19% <0.00%> (-4.77%) ⬇️
node/impl/full/mpool.go 23.47% <0.00%> (-1.74%) ⬇️
extern/sector-storage/sched_worker.go 77.25% <0.00%> (-0.73%) ⬇️
storage/wdpost_run.go 70.25% <0.00%> (-0.43%) ⬇️
chain/messagepool/messagepool.go 57.54% <0.00%> (-0.25%) ⬇️
node/impl/full/state.go 34.46% <0.00%> (+0.24%) ⬆️
chain/messagepool/selection.go 80.52% <0.00%> (+0.40%) ⬆️
storage/wdpost_changehandler.go 98.11% <0.00%> (+0.47%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63f5c8...22d75f4. Read the comment docs.

@magik6k magik6k merged commit 7db4dda into master Aug 27, 2021
@magik6k magik6k deleted the filcloud-info-blocks branch August 27, 2021 17:18
@Shekelme
Copy link

It would be nice if this command also displayed the date of finding for each block in it's output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants