Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lotus-stats: insert miner and network power data as gibibytes to avoid int64 overflows #7194

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

travisperson
Copy link
Contributor

Resolves #6920.

@travisperson travisperson requested a review from a team as a code owner August 26, 2021 23:57
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #7194 (0e8abc1) into master (7c484ca) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7194      +/-   ##
==========================================
+ Coverage   34.71%   34.73%   +0.02%     
==========================================
  Files         685      685              
  Lines       80198    80199       +1     
==========================================
+ Hits        27841    27858      +17     
+ Misses      46678    46667      -11     
+ Partials     5679     5674       -5     
Impacted Files Coverage Δ
tools/stats/metrics.go 0.00% <0.00%> (ø)
chain/actors/builtin/market/v4.go 36.52% <0.00%> (-7.83%) ⬇️
extern/sector-storage/sched_worker.go 77.25% <0.00%> (-0.73%) ⬇️
chain/store/store.go 64.47% <0.00%> (+0.71%) ⬆️
storage/wdpost_changehandler.go 98.58% <0.00%> (+0.94%) ⬆️
extern/storage-sealing/fsm.go 56.62% <0.00%> (+1.20%) ⬆️
itests/kit/blockminer.go 95.23% <0.00%> (+1.58%) ⬆️
storage/wdpost_sched.go 81.18% <0.00%> (+1.98%) ⬆️
chain/sub/incoming.go 52.07% <0.00%> (+2.36%) ⬆️
miner/miner.go 54.30% <0.00%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c484ca...0e8abc1. Read the comment docs.

@magik6k magik6k merged commit c19ee58 into master Aug 27, 2021
@magik6k magik6k deleted the feat/big-data branch August 27, 2021 09:19
@raulk raulk changed the title Insert miner and network power data as gibibytes to avoid int64 overflows lotus-stats: insert miner and network power data as gibibytes to avoid int64 overflows Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lotus-stats tool shows negative power when network power is over ~8 EiB
2 participants