-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix events API timeout handling for nil blocks #7184
fix events API timeout handling for nil blocks #7184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome find! Great that we also extended the test coverage significantly for this edge case 👏
Just need to fix the lint and the test failures, which complain about deal expiration bounds. Not sure if this is related to us modifying the miner actor configuration. It shouldn't be because each test runs in a separate process in CI, so there shouldn't be any cross interaction. Regardless, we should probably reset the value of minerN.DealMinDuration
to the original values with a t.Cleanup()
.
Maybe related to the introduction of MinBlocksDuration
? Although not sure how, because everywhere continues using the zero value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hmm good point 👍 I tried running the test against #7000 and it failed, so I guess we will need the fix here in addition to those changes. |
Oh, wow. I didn't even notice this issue. |
Any reason not to merge this directly to master? |
The events API timeout handler does not take into account nil blocks.
This PR fixes it, and adds a test for deal expiry.