Incoming: improve a log message #7181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Aug 25, 2021
Stebalien
reviewed
Aug 25, 2021
| @@ -308,7 +308,7 @@ func (bv *BlockValidator) Validate(ctx context.Context, pid peer.ID, msg *pubsub | |||
| return pubsub.ValidationReject | |||
| } | |||
|
|
|||
| log.Warnf("cannot validate block message; unknown miner or miner that doesn't meet min power in unsynced chain") | |||
| log.Warnf("cannot validate block message; unknown miner or miner that doesn't meet min power in unsynced chain: %s", blk.Header.Cid()) | |||
There was a problem hiding this comment.
(I'd consider including the miner as well)
Codecov Report
@@ Coverage Diff @@
## master #7181 +/- ##
==========================================
- Coverage 34.74% 34.69% -0.05%
==========================================
Files 685 685
Lines 80188 80188
==========================================
- Hits 27858 27820 -38
- Misses 46656 46701 +45
+ Partials 5674 5667 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I had lying around