fix TestDealPublisher #7173
Merged
fix TestDealPublisher #7173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. No need to slice a slice. 2. Idiomatic filter (https://github.com/golang/go/wiki/SliceTricks).
Otherwise, our nice and deterministic test may keep repeatedly setting the time to _right_ before the timer fires.
Stebalien
commented
Aug 24, 2021
| @@ -384,12 +388,12 @@ func pieceCids(deals []market2.ClientDealProposal) string { | |||
|
|
|||
| // filter out deals that have been cancelled | |||
| func (p *DealPublisher) filterCancelledDeals() { | |||
| i := 0 | |||
| filtered := p.pending[:0] | |||
There was a problem hiding this comment.
This was just a drive-by fix to make the logic here easier to reason about.
| @@ -257,7 +261,7 @@ func (p *DealPublisher) publishAllDeals() { | |||
|
|
|||
| // Filter out any deals that have been cancelled | |||
| p.filterCancelledDeals() | |||
| deals := p.pending[:] | |||
| deals := p.pending | |||
There was a problem hiding this comment.
Also a drive-by fix. There's no need to do this unless p.pending is an array.
Codecov Report
@@ Coverage Diff @@
## master #7173 +/- ##
==========================================
+ Coverage 34.85% 34.87% +0.01%
==========================================
Files 684 684
Lines 80137 80137
==========================================
+ Hits 27934 27945 +11
+ Misses 46518 46510 -8
+ Partials 5685 5682 -3
Continue to review full report at Codecov.
|
|
codecove -> 🤦 |
|
Flaky test disabled in #7176. |
arajasek
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test should be mostly deterministic, but is still failing. I believe this is because:
Unfortunately, I can't reproduce this locally (at all) so I'm mostly just guessing.