Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in SectorAddPieceToAny api impl #7135

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Aug 19, 2021

A value+error can get routed there from https://github.com/filecoin-project/lotus/blob/master/extern/storage-sealing/input.go#L214, which will make go-jsonrpc hide the real error, and instead it will complain about value+error being returned

@magik6k magik6k requested a review from a team as a code owner August 19, 2021 10:58
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks harmless.

@magik6k magik6k enabled auto-merge August 19, 2021 11:12
@magik6k magik6k merged commit fcc3103 into master Aug 19, 2021
@magik6k magik6k deleted the fix/addpiece-errval branch August 19, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants