call string.Repeat always with positive int #7104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
reviewed
Aug 17, 2021
cmd/lotus-miner/sealing.go
Outdated
Comment on lines
106
to
110
| if ramRepeatSpace < 0 { | ||
| ramRepeatSpace = 0 | ||
| ramBar = color.RedString(strings.Repeat("|", ramBarsRes)) + | ||
| color.GreenString(strings.Repeat("|", ramBarsUsed)) + | ||
| strings.Repeat(" ", ramRepeatSpace) | ||
| } else { | ||
| ramBar = color.YellowString(strings.Repeat("|", ramBarsRes)) + | ||
| color.GreenString(strings.Repeat("|", ramBarsUsed)) + | ||
| strings.Repeat(" ", ramRepeatSpace) | ||
| } |
There was a problem hiding this comment.
nit: populate the variable portion of ramBar under the condition, then the static version outside.
| vmemBar := color.YellowString(strings.Repeat("|", vmemBarsRes)) + | ||
| color.GreenString(strings.Repeat("|", vmemBarsUsed)) + | ||
| strings.Repeat(" ", int(barCols)-vmemBarsUsed-vmemBarsRes) | ||
| strings.Repeat(" ", vmemRepeatSpace) |
There was a problem hiding this comment.
Is this guaranteed to be non-negative?
There was a problem hiding this comment.
I am not 100% sure, so better be safe and keep the same pattern as ramBar for simplicity.
nonsense
force-pushed
the
nonsense/fix-repeat-string-negative
branch
from
398433e
to
548865e
Compare
Codecov Report
@@ Coverage Diff @@
## master #7104 +/- ##
==========================================
- Coverage 34.85% 34.79% -0.06%
==========================================
Files 685 685
Lines 80187 80197 +10
==========================================
- Hits 27947 27908 -39
- Misses 46553 46592 +39
- Partials 5687 5697 +10
Continue to review full report at Codecov.
|
Stebalien
approved these changes
Aug 25, 2021
This was referenced Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a report for a panic at:
on tag
m1.3.4Apparently
int(barCols)-ramBarsUsed-ramBarsRessomehow gets negative (calling itramRepeatSpacenow).This PR is making sure
ramRepeatSpaceis set to 0, in case it is negative, and changes the colour of the string from yellow to red in this case.