fix lotus-miner storage-deals set-ask - make sure that ActorAddress works on all miner nodes
#6939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
changed the title
lotus-miner storage-deals set-as - remove calls to miner service; use input from userlotus-miner storage-deals set-ask - remove calls to miner service; use input from user
magik6k
reviewed
Jul 29, 2021
nonsense
force-pushed
the
nonsense/fix-set-ask-for-mra
branch
from
7a29872 to
4dee5d8
Compare
nonsense
changed the title
lotus-miner storage-deals set-ask - remove calls to miner service; use input from userlotus-miner storage-deals set-ask - make sure that ActorAddress works on all miner nodes
jacobheun
added
epic/MRA
release/backport
team/ignite
jacobheun
added
P2
raulk
reviewed
Jul 29, 2021
There was a problem hiding this comment.
Honestly I'm not comfortable doing this. The reason why this works is because it's a side-effect from having copied the miner's metadata store into the markets process. I'm not even sure that was the right thing to do in the first place, and if we merge this, we will be marrying to that approach forever.
|
Closing as this is no longer needed with #6936. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing #6921