Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: fix version check when using gotip #6916

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jul 28, 2021

Gotip version looks like go version devel go1.18..., and we'd try to parse the 'devel' as version

@magik6k magik6k requested a review from a team as a code owner July 28, 2021 17:13
@Stebalien Stebalien enabled auto-merge July 28, 2021 23:53
@Stebalien Stebalien merged commit 742321d into master Jul 29, 2021
@Stebalien Stebalien deleted the fix/make-gotip-ver-check branch July 29, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants