Improve splitstore warmup #6867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
added
epic/splitstore
team/ignite
raulk
approved these changes
Jul 26, 2021
vyzo
force-pushed
the
fix/splitstore-warmup
branch
from
8f397e9
to
57a8eb8
Compare
|
rebased on master and added undefrlow check. |
vyzo
force-pushed
the
fix/splitstore-warmup
branch
from
57a8eb8
to
c52c273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the
checkcommand in #6811 it was observed (to my great surprise) that my discard node actually has some cold references, dating back to the original snapshot.So it appears that the warmup is not capturing all references that it should.
This improves the situation by traversing a full finality worth of state during warmup.