feat(miner deals): create subdir to miner repo for staged deals #6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
force-pushed
the
frrist/miner-temp-file-path
branch
2 times, most recently
from
3014d8a
to
a229b5e
Compare
frrist
commented
Jul 24, 2021
| @@ -607,7 +607,7 @@ func StorageProvider(minerAddress dtypes.MinerAddress, | |||
| df dtypes.StorageDealFilter, | |||
| ) (storagemarket.StorageProvider, error) { | |||
| net := smnet.NewFromLibp2pHost(h) | |||
| store, err := piecefilestore.NewLocalFileStore(piecefilestore.OsPath(r.Path())) | |||
| store, err := piecefilestore.NewLocalFileStore(piecefilestore.OsPath(filepath.Join(r.Path(), "deal-staging"))) | |||
There was a problem hiding this comment.
The next steps could be to make this path value configurable via the miner config (I'm sure this would make @travisperson's life a bit easier). If we think it's worth doing I can add it in. Doing this work will also close: #5591
frrist
commented
Jul 24, 2021
| // this is required due to the method makeDealStaging from cmd/lotus-storage-miner/init.go | ||
| // deal-staging is the directory deal files are staged in before being sealed into sectors | ||
| // for offline deal flow. | ||
| if err := os.MkdirAll(filepath.Join(t, "deal-staging"), 0755); err != nil { |
There was a problem hiding this comment.
This is kinda ugly, but I didn't want to make the Repo responsible for creating this directory since it is used by things other than the miner.
Stebalien
force-pushed
the
frrist/miner-temp-file-path
branch
from
a229b5e
to
ca697c9
Compare
ZenGround0
approved these changes
Aug 16, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5291