ClientFindData: always fetch peer id from chain #6807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
changed the title
Kubuxu
approved these changes
Jul 21, 2021
raulk
approved these changes
Jul 21, 2021
raulk
approved these changes
Jul 21, 2021
magik6k
approved these changes
Jul 21, 2021
|
@nonsense : did the test get added? |
|
Beautiful - thanks.
…On Wed, Jul 21, 2021 at 8:50 AM Anton Evangelatov ***@***.***> wrote:
@BigLep <https://github.com/BigLep> I don't think there is a test for
this case.
We will have one as soon as we finish the lotus-compatibility tests part
of M1 (initial PR at #6765
<#6765> )
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6807 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAU3I6CQCKCT3YEJXRFHYLTY3UDNANCNFSM5AXTG7RA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing
ClientFindDatawhen data about peers in the local store of a node is out-dated.If a client makes a deal with a miner, it keeps the miner's peer id in a local store. In the future if the miner changes its peer id, and the client tries to retrieve the content (datacid),
ClientFindDatawould still be trying to reach the miner on its old peer id, ultimately failing.This is manifested with
Failed to find fileerror in the CLI: