move lotus mount, dag store etc from markets to lotus #6793
Conversation
dirkmc
force-pushed
the
refactor/mv-lotus-mount
branch
from
9f1fde5
to
b6a7a8c
Compare
markets/dagstore/dagstorewrapper.go
Outdated
| ) | ||
|
|
||
| var log = logging.Logger("dagstore-wrapper") | ||
| var gcInterval = 5 * time.Minute |
There was a problem hiding this comment.
We'll probably want this to be configurable via config.yml. I can submit a PR to add a DAG Store configuration. Then that can take the place of MarketsDAGStoreConfig!
There was a problem hiding this comment.
Sounds good 👍
Suggest we do this as a separate PR
markets/dagstore/dagstorewrapper.go
Outdated
| return nil, xerrors.Errorf("failed to create DAG store: %w", err) | ||
| } | ||
|
|
||
| ctx, cancel := context.WithCancel(context.Background()) |
There was a problem hiding this comment.
This is going to be constructed through DI likely. We should take a context.Config in the constructor, and then wire it in the node package to the DI context. I can help with that if you need advice on how to do it!
There was a problem hiding this comment.
Added Start and Stop hooks that call a new Start(ctx) method and the existing Close() method respectively
| @@ -609,9 +609,10 @@ func StorageProvider(minerAddress dtypes.MinerAddress, | |||
| } | |||
|
|
|||
| opt := storageimpl.CustomDealDecisionLogic(storageimpl.DealDeciderFunc(df)) | |||
| shardMigrator := storageimpl.NewShardMigrator(address.Address(minerAddress), ds, dagStore, pieceStore, spn) | |||
There was a problem hiding this comment.
Can we move the shard migrator here too? It too is specific to Lotus, so I think it makes sense to move into the Lotus repo.
(Suggestion: submit another PR on top of this one to avoid bloating this one)
dirkmc
force-pushed
the
refactor/mv-lotus-mount
branch
from
30c1479
to
8becd92
Compare
|
@raulk Merging it as per today's discussion so we can start testing. Please continue leaving comments here and we'll make sure we address them. |
No description provided.