Splitstore: add retention policy option for keeping messages in the hotstore #6775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, its utility goes beyond lookbacks -- it allows nodes running with discard + the retention policy to support other nodes syncing from them, even if they fall behind -- up to the retention interval. So running a booster/bootstrapper with discard and some 30 finalities retention is a very reasonable proposition. |
Stebalien
approved these changes
Jul 19, 2021
|
A test would be nice. |
|
indeed, i'll add one.
…On Mon, Jul 19, 2021, 21:27 Steven Allen ***@***.***> wrote:
A test would be nice.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6775 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAI4SXCNK7URZBTJQMGSU3TYRVCHANCNFSM5AQXPV6A>
.
|
|
Issue for testing: #6834 |
Kubuxu
approved these changes
Jul 22, 2021
magik6k
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that deals have a longish lookback for messages; this adds an option to accommodate them.
cc @ribasushi