Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitstore code reorg #6755

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Jul 14, 2021

A no functional changes refactor on top of #6754 that breaks the gigantic splitstore.go file in smaller files.

There is a small typo fix, whereby I emacs-snafu'ed an nn at the end of a comment.

@vyzo vyzo requested a review from Stebalien July 14, 2021 17:45
@Stebalien Stebalien merged commit c98ab56 into feat/splitstore-refactor Jul 14, 2021
@Stebalien Stebalien deleted the feat/splitstore-refactor-redux branch July 14, 2021 18:11
@Stebalien Stebalien restored the feat/splitstore-refactor-redux branch July 14, 2021 18:13
@Stebalien
Copy link
Member

Oops. I thought this was against master. Re-opening and reverting.

@vyzo
Copy link
Contributor Author

vyzo commented Jul 14, 2021

just do a reset in the base pr, no need to do anything more complciated.

@Stebalien
Copy link
Member

I did... but now I can't reopen this one. Can you?

@vyzo vyzo deleted the feat/splitstore-refactor-redux branch July 14, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants