handleCommitFailed remove checkPrecommit #6593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
especially ticket expired |
|
Sorry, there are some problems with this submission, it is too rough. but ticket expired this judgment is unreasonable |
magik6k
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Thanks!
- checkPrecommit was also dropped in remove precommit check in handleCommitFailed #6634
- The
SectorRetrySubmitCommiton batch error will be merged in Fast-path retry submitting commit aggregate if commit is still valid #6638
|
(#6638 was merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the sector commits a COMMIT message and fails, for example, there is not enough money. After retry (enough money) the expectation is raised, but this logic will make it fail