Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itests/kit: add guard to ensure imports from tests only. #6445

Merged
merged 1 commit into from
Jun 10, 2021
Merged

itests/kit: add guard to ensure imports from tests only. #6445

merged 1 commit into from
Jun 10, 2021

Conversation

raulk
Copy link
Member

@raulk raulk commented Jun 10, 2021

No description provided.

@raulk raulk requested a review from magik6k June 10, 2021 11:06
magik6k
magik6k approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a hack, but it seems to work

@magik6k magik6k merged commit adaf789 into master Jun 10, 2021
@magik6k magik6k deleted the raulk/itests-init-guard branch June 10, 2021 11:49
@raulk
Copy link
Member Author

raulk commented Jun 10, 2021

Unfortunately it seems to be the only accurate way to detect when we're running inside a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulk @magik6k