Update to latest proofs #6006
Merged
Update to latest proofs #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
|
Fixes #5816 |
magik6k
approved these changes
Apr 12, 2021
|
Verified manually by creating a node, importing those 2 snapshots:
|
Stebalien
reviewed
Apr 12, 2021
| @@ -81,3 +81,6 @@ const PropagationDelaySecs = uint64(6) | |||
|
|
|||
| // BootstrapPeerThreshold is the minimum number peers we need to track for a sync worker to start | |||
| const BootstrapPeerThreshold = 4 | |||
|
|
|||
| // we skip checks on message validity in this block to sidestep the zero-bls signature | |||
| var WhitelistedBlock = MustParseCid("bafy2bzaceapyg2uyzk7vueh3xccxkuwbz3nxewjyguoxvhx77malc2lzn2ybi") | |||
There was a problem hiding this comment.
Can we have a set of WhitelistedBlocks and maybe a bitfield/object describing what checks are skipped? E.g.,
type SkippedChecks {
...
}
var WhitelistedBlocks map[cid.Cid]SkippedChecks
There was a problem hiding this comment.
I don't think we plan to have more than one of those blocks ever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to test the whitelisted block thing.
lotus-shed sync validate bafy2bzaceapyg2uyzk7vueh3xccxkuwbz3nxewjyguoxvhx77malc2lzn2ybi bafy2bzaced5qjsl2jp4rlxjrwsxovyvayswsufxbst6yan7tijd27cktznxl6 bafy2bzaceb7syjfrkoy4yujiumrdvw23kchm2ilvjyul4yst3tkl7ce62royk bafy2bzacebruywjijmeqyrwsv7m3mtokjkibhgsoymsbopet4f7qzb2dkikkg bafy2bzaceber4ccef75m4ufhq27cxshtuj552c2g5e3psx62557b45it7d6qk. Should successfully validate.