Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storagefsm: Apply global events even in broken states #5962

Merged
merged 2 commits into from
Apr 11, 2021
Merged

storagefsm: Apply global events even in broken states #5962

merged 2 commits into from
Apr 11, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 5, 2021

Fixes #3982

@arajasek
Copy link
Contributor

arajasek commented Apr 5, 2021

Give us tests, we crave tests

arajasek
arajasek approved these changes Apr 10, 2021
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproved now that test craving has been satisfied

@magik6k magik6k merged commit b54b130 into master Apr 11, 2021
@magik6k magik6k deleted the fix/storagefsm-allow-broken-global branch April 11, 2021 20:30
@magik6k magik6k mentioned this pull request Apr 13, 2021
Closed
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be able to remove sectors that are in invalid state.
2 participants
@magik6k @arajasek