Update to go-fil-markets-v1.2.5

[dirkmc]

Fixes #5829
Fixes #5895

Note: This version of markets still contains some known issues with retrieval, that will be fixed in a subsequent release (For example if the connection goes down during a retrieval, the deal will not recover).

Major improvements:

• Fix retrieval bug where provider would try to send blocks before unsealing had completed
• Fix bug on client side with handling non-zero unseal / zero price-per-byte retrieval deal
• Use Deal ID based on time instead of a stateful counter - helps avoid state sync issues between client and provider

For a detailed list of changes, see the changelog in go-fil-markets (from v1.2.3 - v1.2.5):
https://github.com/filecoin-project/go-fil-markets/blob/master/CHANGELOG.md

Tasks:

• Run testground test that makes a deal between lotus client / provider of v1.6.0 / this branch
• Run manual storage and retrieval deal
  • v1.6.0 client -> this branch miner
    • Storage deal
    • Retrieval deal
  • this branch client -> v1.6.0 miner
    • Storage deal
    • Retrieval deal
  • this branch client -> this branch miner
    • Storage deal
    • Retrieval deal
• Upgrade client / miner from v1.6.0 -> this branch and back, to make sure there aren't any data migration issues
  I found there was an issue downgrading from this branch to v1.6.0 - see comment below

[arajasek]

Regarding

Run manual storage and retrieval deal
this branch client -> v1.6.0 miner
Storage deal
Retrieval deal

Obviously worth testing, but we do expect it so succeed, right? Like we haven't changed any of the protocols themselves, right>

[dirkmc]

we do expect it so succeed, right?

Yes, I'm not expecting we'll see any problems, it's more of a sanity check

[dirkmc]

Testground tests:

Lotus master + markets v1.2.5:  4a3261a
Lotus v1.6.0:                   3fc23a7

[This branch client / v1.6.0 miner]

https://ci.testground.ipfs.team/logs?task_id=c1ng00l5p7a9ldjbbuv0
LOTUS_VERSION_CLIENT=4a3261a LOTUS_VERSION_MINER=3fc23a7 testground run composition -f ./_compositions/baseline-k8s-1-1-versions.toml --metadata-commit= 4a3261a --metadata-repo=filecoin-project/lotus --metadata-branch=feat/markets-v1.2.5-rc1

[v1.6.0 client / This branch miner]

https://ci.testground.ipfs.team/logs?task_id=c1ng4vt5p7a9ldjbbuvg
LOTUS_VERSION_CLIENT=3fc23a7 LOTUS_VERSION_MINER=4a3261a testground run composition -f ./_compositions/baseline-k8s-1-1-versions.toml --metadata-commit= 4a3261a --metadata-repo=filecoin-project/lotus --metadata-branch=feat/markets-v1.2.5-rc1

Manual Tests:

   Client                          Provider
=============================================================
1. lotus master + marketsv1.2.5    lotus v1.6.0 + marketsv1.2.5  ✓
2. lotus master + marketsv1.2.5    lotus v1.6.0                  ✓
3. lotus master + marketsv1.2.5    lotus master + marketsv1.2.5  ✓
4. lotus v1.6.0                    lotus master + marketsv1.2.5  ✓

[dirkmc]

Testing of upgrade / downgrade

Client

Note: I did see an issue downgrading from this branch to v1.6.0 - it was not possible to make a retrieval deal on the client after downgrading from this branch to v1.6.0:

$ lotus client retrieve --miner f012345 bafykbzacaabytx65vf2n2daoallyvtrc43pguqvpmofgehncs6p5tk2qbg7pa /tmp/myfile

> Recv: 0 B, Paid 0 FIL, ClientEventOpen (DealStatusNew)
ERROR: retrieval failed: Retrieve failed: Error migrating database: never reached target database version

After downgrading the client from this branch to v1.6.0 it was possible to make a storage deal.

Miner

After downgrading the miner from this branch to v1.6.0 I did not see any issues - I was able to successfully make a storage and retrieval deal.