storagefsm: Trigger input processing when below limits #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
changed the title
magik6k
commented
Mar 12, 2021
| shouldUpdateInput := m.stats.updateSector(cfg, m.minerSectorID(state.SectorNumber), state.State) | ||
|
|
||
| // trigger more input processing when we've dipped below max sealing limits | ||
| if shouldUpdateInput { |
There was a problem hiding this comment.
changing this to shouldUpdateInput && false makes TestBatchDealInput fail reliably
Stebalien
approved these changes
Mar 12, 2021
Stebalien
approved these changes
Mar 12, 2021
magik6k
commented
Mar 12, 2021
Comment on lines
+403
to
+404
| // update stats early, fsm planner would do that async | ||
| m.stats.updateSector(cfg, m.minerSectorID(sid), UndefinedSectorState) |
There was a problem hiding this comment.
Without this we could end up creating a bunch of sectors at once, and start more parallel work than specified by the max sealing sector config.
There was a problem hiding this comment.
This seems a bit brittle. Can we have a m.createSector function that calls NewSector and updates the stats?
Stebalien
approved these changes
Mar 12, 2021
Comment on lines
+403
to
+404
| // update stats early, fsm planner would do that async | ||
| m.stats.updateSector(cfg, m.minerSectorID(sid), UndefinedSectorState) |
There was a problem hiding this comment.
This seems a bit brittle. Can we have a m.createSector function that calls NewSector and updates the stats?
Stebalien
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a miner starts processing more deals in parallel than the configured sealing limits, we wouldn't start processing more deals after the first batch of sectors got sealed.
This should fix that case