Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node status api #5767

Merged
merged 10 commits into from
Mar 16, 2021
Merged

node status api #5767

merged 10 commits into from
Mar 16, 2021

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Mar 10, 2021

Closes #5762

@vyzo vyzo requested a review from Kubuxu March 10, 2021 17:38
@vyzo
Copy link
Contributor Author

vyzo commented Mar 10, 2021

@magik6k what do you want to do with the chain health thing?

node/impl/full.go Outdated Show resolved Hide resolved
node/impl/full.go Outdated Show resolved Hide resolved
node/impl/full.go Outdated Show resolved Hide resolved
node/impl/full.go Outdated Show resolved Hide resolved
@vyzo
Copy link
Contributor Author

vyzo commented Mar 10, 2021

we briefly discussed the chain health status with @magik6k and I will add some statistics on average number of blocks in the last finality (and also last 100 epochs).

I will make this optional with a boolean argument, as it is potentially expensive and we might be calling status a lot for message sending.

@vyzo vyzo force-pushed the feat/node-status-api branch from f6d26fa to 77f58b5 Compare March 12, 2021 11:16
@vyzo
Copy link
Contributor Author

vyzo commented Mar 12, 2021

rebased on master

@vyzo vyzo mentioned this pull request Mar 12, 2021
@vyzo vyzo force-pushed the feat/node-status-api branch from 77f58b5 to 522ffab Compare March 16, 2021 07:35
@vyzo vyzo changed the base branch from master to epic/robust-message-management March 16, 2021 07:36
@vyzo vyzo merged commit 4498354 into epic/robust-message-management Mar 16, 2021
@vyzo vyzo deleted the feat/node-status-api branch March 16, 2021 07:43
@vyzo vyzo mentioned this pull request Mar 16, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeStatus API Endpoint for checking node health
2 participants