Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata datastore log #5755

Merged
merged 6 commits into from
Mar 10, 2021
Merged

Metadata datastore log #5755

merged 6 commits into from
Mar 10, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 9, 2021

This makes us write 'continuous' backups to /.lotus[miner]/kvlog/metadata, which means that when the metadata leveldb gets corrupted, it's still very easy to recover the latest state

@magik6k magik6k requested a review from arajasek March 9, 2021 22:48
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice...I assume it doesn't slow anything down, right?

@magik6k
Copy link
Contributor Author

magik6k commented Mar 10, 2021

It doesn't have measurable impact, the metadata datastore isn't written all that much

Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, but is there a replay procedure to restore from the log?

lib/backupds/datastore.go Outdated Show resolved Hide resolved
lib/backupds/log.go Outdated Show resolved Hide resolved
@magik6k
Copy link
Contributor Author

magik6k commented Mar 10, 2021

looks ok, but is there a replay procedure to restore from the log?

Yep, normal backup restore works with those files (only manual for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants