Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/api no dep build #5729

Merged
merged 5 commits into from
Mar 9, 2021
Merged

Feat/api no dep build #5729

merged 5 commits into from
Mar 9, 2021

Conversation

whyrusleeping
Copy link
Member

This removes the api packages dependency on the build package, which transitively removes its dependency on the chain/actors/policy package which depends on every single version of the specs actors, which is a fairly bad time for people who just want to use the lotus api.

further extractions coming as my quest to have a very lightweight api package continues.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a slight breaking change by renaming Version to APIVersion, but avoiding that is a bit tricky unless we want to call what's now called Version something like BasicVersion.

@magik6k magik6k merged commit 1c62d7a into next Mar 9, 2021
@magik6k magik6k deleted the feat/api-no-dep-build branch March 9, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants