ensure we can't dispute a correct window post #5406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
approved these changes
Jan 25, 2021
| @@ -211,3 +211,16 @@ func TestWindowPostDispute(t *testing.T) { | |||
|
|
|||
| test.TestWindowPostDispute(t, builder.MockSbBuilder, 2*time.Millisecond) | |||
| } | |||
|
|
|||
| func TestWindowPostDisputeFails(t *testing.T) { | |||
There was a problem hiding this comment.
In case anyone is wondering like me, yes, this gets run in the post-dispute CI -> https://circle-production-customer-artifacts.s3.amazonaws.com/picard/5d174a4f4cf8a70001f53d90/600b5238788ab961dcfe50e3-0-build/artifacts/tmp/test-artifacts/window-post-dispute.json?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20210125T153126Z&X-Amz-SignedHeaders=host&X-Amz-Expires=60&X-Amz-Credential=AKIAJR3Q6CR467H7Z55A%2F20210125%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Signature=490d8aa85bbe7d3816084b58c31dbfebfbb728804c6bc6edf132a25270962387
There was a problem hiding this comment.
Ah, yes... And the reason the TestWindowPostDispute and TestWIndowedPost don't run at the same time... is the ed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to make sure disputing a valid window post fails.