shed bitfield: Cleanup, add merge command #5047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zgfzgf
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
reviewed
Nov 30, 2020
Comment on lines
-113
to
-119
| Flags: []cli.Flag{ | ||
| &cli.StringFlag{ | ||
| Name: "enc", | ||
| Value: "base64", | ||
| Usage: "specify input encoding to parse", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I'm pretty sure this flag is needed
There was a problem hiding this comment.
super are already enc
use func Unified use of the upper level enc
There was a problem hiding this comment.
Name: "bitfield",
Usage: "Bitfield analyze tool",
Description: "analyze bitfields",
Flags: []cli.Flag{
&cli.StringFlag{
Name: "enc",
Value: "base64",
Usage: "specify input encoding to parse",
},
},
bibibong
pushed a commit
to EpiK-Protocol/go-epik
that referenced
this pull request
Feb 22, 2021
shed bitfield: Cleanup, add merge command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize code
use func
add merge