Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chainstore tipset leak #5037

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Fix chainstore tipset leak #5037

merged 2 commits into from
Nov 30, 2020

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Nov 27, 2020

It is a bit of a unortodox fix but it works.
See the comment in chainstore.

Jakub Sztandera added 2 commits November 26, 2020 23:37
@Kubuxu
Copy link
Contributor Author

Kubuxu commented Nov 27, 2020

I have a node running with this, len(cs.tipsets) right now stabilized at ~1100.

arajasek
arajasek approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe only trigger the deletion when cs.tipsets grows above a certain size?

@magik6k magik6k merged commit 8382977 into master Nov 30, 2020
@magik6k magik6k deleted the fix/chainstr-tipset-leak branch November 30, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

@magik6k magik6k magik6k approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kubuxu @magik6k @arajasek