fix get sector bug #4976
Merged
fix get sector bug #4976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlhwdsz
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
reviewed
Nov 23, 2020
chain/actors/builtin/miner/v2.go
Outdated
Comment on lines
89
to
91
| if !ok { | ||
| return nil, xerrors.Errorf("sector %d not found", num) | ||
| } |
There was a problem hiding this comment.
This isn't correct, some callers of this method expect a nil value when the sectors isn't found
There was a problem hiding this comment.
Got it. I modified the code elsewhere instead, please review it again.
zlhwdsz
force-pushed
the
fix-get-sector
branch
from
b7761c3
to
721120f
Compare
Kubuxu
approved these changes
Nov 23, 2020
magik6k
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a panic bug when check nonexistent sectors with the following command:
lotus state sector [miner address] [sector number]