Fix init actor address map diffing #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace logic in predicates
frrist
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
frrist
commented
Nov 16, 2020
Comment on lines
-572
to
-575
| _, found, err := newState.ResolveAddress(newAddress) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Motivation for change lies in the bug here. This should be looking in the oldState to see if a new address has been added. New ADT logic avoids this bug.
frrist
force-pushed
the
frrist/fix-init-pred
branch
from
f73f792
to
d25e5d1
Compare
magik6k
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace init actor address map diffing with generic adt diffing logics
Optimize other diffing methods by calling Diff* iff adt CID's are different.