3749: Do not attempt to send a message if the sender balance is 0. #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennijuju
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
jennijuju
changed the title
jennijuju
force-pushed
the
3749-zero-balance-account
branch
from
8601790 to
be6249f
Compare
arajasek
reviewed
Nov 9, 2020
| @@ -631,6 +632,10 @@ func (mp *MessagePool) checkBalance(m *types.SignedMessage, curTs *types.TipSet) | |||
| return xerrors.Errorf("failed to check sender balance: %s: %w", err, ErrSoftValidationFailure) | |||
| } | |||
|
|
|||
| if balance == abi.NewTokenAmount(0) { | |||
There was a problem hiding this comment.
FYI, this isn't the right check. It will return true if the fields of the two abi.TokenAmount structs (balance and abi.NewTokenAmount(0)) are the same, which will be false. Use the IsZero() method instead.
For more: https://medium.com/learning-the-go-programming-language/comparing-values-in-go-8f7b002e767a.
|
Thanks for this, but I don't think it's needed, see note in #3749. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arajasek this is to address your suggestion for #3749, please feel free to close both pr & issue if you no longer think it's necessary!